HyukjinKwon commented on code in PR #39400:
URL: https://github.com/apache/spark/pull/39400#discussion_r1062125012


##########
python/pyspark/sql/tests/connect/test_parity_functions.py:
##########
@@ -68,30 +60,14 @@ def test_date_add_function(self):
     def test_date_sub_function(self):
         super().test_date_sub_function()
 
-    @unittest.skip("Fails in Spark Connect, should enable.")
-    def test_dayofweek(self):
-        super().test_dayofweek()
-
     @unittest.skip("Fails in Spark Connect, should enable.")
     def test_explode(self):
         super().test_explode()
 
-    @unittest.skip("Fails in Spark Connect, should enable.")
-    def test_first_last_ignorenulls(self):
-        super().test_first_last_ignorenulls()
-
-    @unittest.skip("Fails in Spark Connect, should enable.")
-    def test_function_parity(self):

Review Comment:
   Let's exclude this. It uses `SparkContect` that Spark Connect doesn't 
support.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to