[GitHub] [spark] HyukjinKwon commented on issue #25593: [SPARK-27992][PYTHON][BRANCH-2.4] Allow Python to join with connection thread to propagate errors

2019-08-27 Thread GitBox
HyukjinKwon commented on issue #25593: [SPARK-27992][PYTHON][BRANCH-2.4] Allow 
Python to join with connection thread to propagate errors
URL: https://github.com/apache/spark/pull/25593#issuecomment-525157779
 
 
   Yes, please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on issue #25593: [SPARK-27992][PYTHON][BRANCH-2.4] Allow Python to join with connection thread to propagate errors

2019-08-27 Thread GitBox
HyukjinKwon commented on issue #25593: [SPARK-27992][PYTHON][BRANCH-2.4] Allow 
Python to join with connection thread to propagate errors
URL: https://github.com/apache/spark/pull/25593#issuecomment-525153808
 
 
   Those partial results can actually be reproduced, for instance as below:
   
   ```python
   spark.conf.set("spark.sql.execution.arrow.enabled", True)
   spark.range(0, 33, 1, 100).toPandas()
   ```
   
   ```
   ...
   75897  75897
   75898  75898
   75899  75899
   
   [75900 rows x 1 columns]
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on issue #25593: [SPARK-27992][PYTHON][BRANCH-2.4] Allow Python to join with connection thread to propagate errors

2019-08-27 Thread GitBox
HyukjinKwon commented on issue #25593: [SPARK-27992][PYTHON][BRANCH-2.4] Allow 
Python to join with connection thread to propagate errors
URL: https://github.com/apache/spark/pull/25593#issuecomment-525151293
 
 
   I am going to add a test against SPARK-28881 first into the master branch 
first. And then port the test into here to target branch-2.4.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on issue #25593: [SPARK-27992][PYTHON][BRANCH-2.4] Allow Python to join with connection thread to propagate errors

2019-08-26 Thread GitBox
HyukjinKwon commented on issue #25593: [SPARK-27992][PYTHON][BRANCH-2.4] Allow 
Python to join with connection thread to propagate errors
URL: https://github.com/apache/spark/pull/25593#issuecomment-525150529
 
 
   Otherwise, we should revert #21546 but ironically seems having a different 
fix from master will have less risk from my perspective because #21546 is too 
big and old. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on issue #25593: [SPARK-27992][PYTHON][BRANCH-2.4] Allow Python to join with connection thread to propagate errors

2019-08-26 Thread GitBox
HyukjinKwon commented on issue #25593: [SPARK-27992][PYTHON][BRANCH-2.4] Allow 
Python to join with connection thread to propagate errors
URL: https://github.com/apache/spark/pull/25593#issuecomment-525149871
 
 
   cc @cloud-fan, @gatorsmile, @BryanCutler,
   Also cc @dongjoon-hyun, I think we should block Spark 2.4.4 RC2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org