[GitHub] [spark] LantaoJin commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype
LantaoJin commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-652112555 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype
LantaoJin commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-650675131 Before that, I think we still need to fix the problem describe in the description. https://github.com/apache/spark/pull/28833#pullrequestreview-435416974 is a good idea to handle it. I file #28935 as a new fixing. @maropu @cloud-fan @wangyum This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype
LantaoJin commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-648610855 I think I can reuse this PR to do that as this patch is no need anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype
LantaoJin commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-648515582 Success in Hive: ```sql create table t (col1 struct); create table t (col1 array); ``` Fail with `NoViableAltException` in Hive: ```sql create table t (col1 struct); create table t (col1 array); ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin commented on pull request #28833: [SPARK-20680][SQL] Make null type in Spark sql to be compatible with Hive void datatype
LantaoJin commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-647957153 Emmm, thanks @wangyum . I think we should keep the same behavior with Hive2.x. Throw more readable exceptions for below SQLs. ```sql create table t as select 1 x, null z from dual; create table t as select null as null_col create table t (v void); ``` @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
