[GitHub] [spark] MaxGekk commented on a diff in pull request #39389: [SPARK-41574][SQL] Assign name to _LEGACY_ERROR_TEMP_2009

2023-01-07 Thread GitBox 


MaxGekk commented on code in PR #39389:
URL: https://github.com/apache/spark/pull/39389#discussion_r1063978774


##
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##
@@ -378,10 +378,9 @@ private[sql] object QueryExecutionErrors extends 
QueryErrorsBase {
 )
   }
 
-  def dataTypeOperationUnsupportedError(): SparkUnsupportedOperationException 
= {
-new SparkUnsupportedOperationException(
-  errorClass = "_LEGACY_ERROR_TEMP_2009",
-  messageParameters = Map.empty)
+  def dataTypeOperationUnsupportedError(): Throwable = {

Review Comment:
   Please, move it to `QueryCompilationErrors`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] MaxGekk commented on a diff in pull request #39389: [SPARK-41574][SQL] Assign name to _LEGACY_ERROR_TEMP_2009

2023-01-04 Thread GitBox 


MaxGekk commented on code in PR #39389:
URL: https://github.com/apache/spark/pull/39389#discussion_r1062135726


##
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##
@@ -378,10 +378,9 @@ private[sql] object QueryExecutionErrors extends 
QueryErrorsBase {
 )
   }
 
-  def dataTypeOperationUnsupportedError(): SparkUnsupportedOperationException 
= {
-new SparkUnsupportedOperationException(
-  errorClass = "_LEGACY_ERROR_TEMP_2009",
-  messageParameters = Map.empty)
+  def dataTypeOperationUnsupportedError(): Throwable = {
+SparkException.internalError(
+  s"""Operation dataType is not supported""")

Review Comment:
   ```suggestion
 "The operation `dataType` is not supported.")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org