[GitHub] [spark] MaxGekk commented on issue #26438: [SPARK-29408][SQL] Support sign before `interval` in interval literals

2019-11-10 Thread GitBox
MaxGekk commented on issue #26438: [SPARK-29408][SQL] Support sign before 
`interval` in interval literals
URL: https://github.com/apache/spark/pull/26438#issuecomment-552177033
 
 
   > It's PostgreSQL 12, right?
   
   Originally, I tested on 11.5 but I see the same on 12.0:
   ```
   psql (12.0 (Homebrew petere/postgresql))
   Type "help" for help.
   
   maxim=# select +interval '-1 month 1 day -1 second';
   ERROR:  operator does not exist: + interval
   LINE 1: select +interval '-1 month 1 day -1 second';
  ^
   HINT:  No operator matches the given name and argument type. You might need 
to add an explicit type cast.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] MaxGekk commented on issue #26438: [SPARK-29408][SQL] Support sign before `interval` in interval literals

2019-11-10 Thread GitBox
MaxGekk commented on issue #26438: [SPARK-29408][SQL] Support sign before 
`interval` in interval literals
URL: https://github.com/apache/spark/pull/26438#issuecomment-552173293
 
 
   jenkins, retest this, please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] MaxGekk commented on issue #26438: [SPARK-29408][SQL] Support sign before `interval` in interval literals

2019-11-09 Thread GitBox
MaxGekk commented on issue #26438: [SPARK-29408][SQL] Support sign before 
`interval` in interval literals
URL: https://github.com/apache/spark/pull/26438#issuecomment-552171915
 
 
   While comparing to PostgreSQL, I have found it doesn't support '+' before 
interval:
   ```sql
   maxim=# select +interval '-1 month 1 day -1 second';
   ERROR:  operator does not exist: + interval
   LINE 1: select +interval '-1 month 1 day -1 second';
  ^
   HINT:  No operator matches the given name and argument type. You might need 
to add an explicit type cast.
   ```
   @dongjoon-hyun Shall I support only `-`? or `+` is ok too?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org