[GitHub] [spark] MaxGekk commented on pull request #37322: [SPARK-39905][SQL][TESTS] Remove `checkErrorClass()` and use `checkError()` instead
MaxGekk commented on PR #37322: URL: https://github.com/apache/spark/pull/37322#issuecomment-1198880973 Merging to master. Thank you, @gengliangwang for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37322: [SPARK-39905][SQL][TESTS] Remove `checkErrorClass()` and use `checkError()` instead
MaxGekk commented on PR #37322: URL: https://github.com/apache/spark/pull/37322#issuecomment-1198870290 @anchovYu @cloud-fan @HyukjinKwon @gengliangwang Could you review this PR, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37322: [SPARK-39905][SQL][TESTS] Remove `checkErrorClass()` and use `checkError()` instead
MaxGekk commented on PR #37322: URL: https://github.com/apache/spark/pull/37322#issuecomment-1197784056 @cloud-fan @HyukjinKwon @gengliangwang Could you have a look at the PR, please. I wanna switch Serge's checkError completely, and extend checkError() to check query context as the next step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37322: [SPARK-39905][SQL][TESTS] Remove `checkErrorClass()` and use `checkError()` instead
MaxGekk commented on PR #37322: URL: https://github.com/apache/spark/pull/37322#issuecomment-1197681046 cc @srielau -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
