[GitHub] [spark] MaxGekk commented on pull request #41091: [SPARK-39281][SQL] Speed up Timestamp type inference with legacy format in JSON/CSV data source
MaxGekk commented on PR #41091: URL: https://github.com/apache/spark/pull/41091#issuecomment-1549612885 +1, LGTM. Merging to master. Thank you, @Hisoka-X. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #41091: [SPARK-39281][SQL] Speed up Timestamp type inference with legacy format in JSON/CSV data source
MaxGekk commented on PR #41091: URL: https://github.com/apache/spark/pull/41091#issuecomment-1546829442 @Hisoka-X Please, resolve the conflicts and rebase on the recent master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #41091: [SPARK-39281][SQL] Speed up Timestamp type inference with legacy format in JSON/CSV data source
MaxGekk commented on PR #41091: URL: https://github.com/apache/spark/pull/41091#issuecomment-1542426882 > Can I create a PR for add benchmarks for type inference when string input are not valid timestamps Yep. Let's do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
