amaliujia commented on PR #38491: URL: https://github.com/apache/spark/pull/38491#issuecomment-1308120960
@dengziming I have missed this PR because there was no JIRA created under https://issues.apache.org/jira/browse/SPARK-39375 (I was monitoring works happened there). Since you are doing this change, can you create a JIRA for removing unused code (then update PR title with the JIRA included) and BTW remove some other unused code in connect project? I am seeing one example at https://github.com/apache/spark/blob/0add57a1c0290a158666027afb3e035728d2dcee/connector/connect/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala#L61. There are also unused imports probably existing that we can further clean up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
