[GitHub] [spark] beliefer commented on a diff in pull request #41424: [SPARK-43913][SQL] Assign names to the error class _LEGACY_ERROR_TEMP_[2426-2432]
beliefer commented on code in PR #41424: URL: https://github.com/apache/spark/pull/41424#discussion_r1216524958 ## core/src/main/resources/error/error-classes.json: ## @@ -1834,6 +1849,11 @@ ], "sqlState" : "42K05" }, + "RESOLVED_ATTRIBUTE_MISSING_FROM_INPUT" : { +"message" : [ + "" Review Comment: Got it. But it seems not about `UNRESOLVED_COLUMN`. How about `MISSING_ATTRIBUTES` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #41424: [SPARK-43913][SQL] Assign names to the error class _LEGACY_ERROR_TEMP_[2426-2432]
beliefer commented on code in PR #41424: URL: https://github.com/apache/spark/pull/41424#discussion_r1216524958 ## core/src/main/resources/error/error-classes.json: ## @@ -1834,6 +1849,11 @@ ], "sqlState" : "42K05" }, + "RESOLVED_ATTRIBUTE_MISSING_FROM_INPUT" : { +"message" : [ + "" Review Comment: Got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #41424: [SPARK-43913][SQL] Assign names to the error class _LEGACY_ERROR_TEMP_[2426-2432]
beliefer commented on code in PR #41424: URL: https://github.com/apache/spark/pull/41424#discussion_r1215258624 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/CreateTablePartitioningValidationSuite.scala: ## @@ -42,7 +42,7 @@ class CreateTablePartitioningValidationSuite extends AnalysisTest { assert(!plan.resolved) assertAnalysisError(plan, Seq( Review Comment: I forgot it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #41424: [SPARK-43913][SQL] Assign names to the error class _LEGACY_ERROR_TEMP_[2426-2432]
beliefer commented on code in PR #41424: URL: https://github.com/apache/spark/pull/41424#discussion_r1215258513 ## core/src/main/resources/error/error-classes.json: ## @@ -1834,6 +1849,11 @@ ], "sqlState" : "42K05" }, + "RESOLVED_ATTRIBUTE_MISSING_FROM_INPUT" : { +"message" : [ + "" Review Comment: So we need change it as an internal error ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org