[GitHub] [spark] c21 commented on pull request #37264: [SPARK-39849][SQL] Dataset.as(StructType) fills missing new columns with null value

2022-07-29 Thread GitBox


c21 commented on PR #37264:
URL: https://github.com/apache/spark/pull/37264#issuecomment-1199763054

   @cloud-fan sure, will open a PR for changing API doc. Missed that too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] c21 commented on pull request #37264: [SPARK-39849][SQL] Dataset.as(StructType) fills missing new columns with null value

2022-07-28 Thread GitBox


c21 commented on PR #37264:
URL: https://github.com/apache/spark/pull/37264#issuecomment-1198868034

   The PR is ready for review again, thanks @cloud-fan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] c21 commented on pull request #37264: [SPARK-39849][SQL] Dataset.as(StructType) fills missing new columns with null value

2022-07-24 Thread GitBox


c21 commented on PR #37264:
URL: https://github.com/apache/spark/pull/37264#issuecomment-1193279936

   cc @dilipbiswal would be great if you can take a look as well, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] c21 commented on pull request #37264: [SPARK-39849][SQL] Dataset.as(StructType) fills missing new columns with null value

2022-07-24 Thread GitBox


c21 commented on PR #37264:
URL: https://github.com/apache/spark/pull/37264#issuecomment-1193279827

   cc @cloud-fan and @HyukjinKwon - could you help take a look when you have 
time? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org