[GitHub] [spark] cloud-fan commented on issue #24107: [SPARK-27174][SQL] Add support for casting integer types to binary

2019-03-22 Thread GitBox
cloud-fan commented on issue #24107: [SPARK-27174][SQL] Add support for casting 
integer types to binary
URL: https://github.com/apache/spark/pull/24107#issuecomment-475702540
 
 
   thanks, merging to master!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #24107: [SPARK-27174][SQL] Add support for casting integer types to binary

2019-03-15 Thread GitBox
cloud-fan commented on issue #24107: [SPARK-27174][SQL] Add support for casting 
integer types to binary
URL: https://github.com/apache/spark/pull/24107#issuecomment-473328705
 
 
   Then I'm ok with supporting it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #24107: [SPARK-27174][SQL] Add support for casting integer types to binary

2019-03-15 Thread GitBox
cloud-fan commented on issue #24107: [SPARK-27174][SQL] Add support for casting 
integer types to binary
URL: https://github.com/apache/spark/pull/24107#issuecomment-473319954
 
 
   what's the current behavior in Spark when casting int to binary? fail or 
return null?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #24107: [SPARK-27174][SQL] Add support for casting integer types to binary

2019-03-15 Thread GitBox
cloud-fan commented on issue #24107: [SPARK-27174][SQL] Add support for casting 
integer types to binary
URL: https://github.com/apache/spark/pull/24107#issuecomment-473307199
 
 
   It may be convenient for some use cases, but it may also confuse others if 
only Spark has this behavior. Can you check with other databases?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] cloud-fan commented on issue #24107: [SPARK-27174][SQL] Add support for casting integer types to binary

2019-03-15 Thread GitBox
cloud-fan commented on issue #24107: [SPARK-27174][SQL] Add support for casting 
integer types to binary
URL: https://github.com/apache/spark/pull/24107#issuecomment-473299940
 
 
   CAST is a pretty standard SQL function, we should make sure our behavior 
align with the SQL spec and mainstream SQL systems.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org