[GitHub] [spark] cloud-fan commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`
cloud-fan commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-552322442 so let's keep the existing behavior if pgsql dialect is set, and fail for invalid bounds otherwise. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`
cloud-fan commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-549441034 Since this is only for interval literal, I think it doesn't hurt if we fail invalid string format. The oracle behavior looks more reasonable to me, we can try more to see if that's a common behavior. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`
cloud-fan commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-549272475 Does SQL spec define the behavior? I tried oracle and it fails if the from/to field doesn't match the actual value. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()`
cloud-fan commented on issue #26358: [SPARK-29712][SQL] Take into account the left bound in `fromDayTimeString()` URL: https://github.com/apache/spark/pull/26358#issuecomment-549253281 > the reset is not performed if spark.sql.dialect = PostgreSQL. Do you mean pgsql has a different behavior? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
