[GitHub] [spark] cloud-fan commented on pull request #29062: [SPARK-32237][SQL] Resolve hint in CTE
cloud-fan commented on pull request #29062: URL: https://github.com/apache/spark/pull/29062#issuecomment-662798239 merged to master, thanks! @LantaoJin can you send a backport to 3.0? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29062: [SPARK-32237][SQL] Resolve hint in CTE
cloud-fan commented on pull request #29062: URL: https://github.com/apache/spark/pull/29062#issuecomment-662569097 The patch LGTM. It will be great if you can take a look at 2.4 and see if there is an easy fix to make your tests pass. We did a big refactor about CTE substitution in 3.0 and I don't know how hard it is to fix the bug in 2.4. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29062: [SPARK-32237][SQL] Resolve hint in CTE
cloud-fan commented on pull request #29062: URL: https://github.com/apache/spark/pull/29062#issuecomment-661883229 the patch itself looks fine. > AnalysisException: cannot resolve 'cte.id' given input columns: [cte.data, cte.id]; Do you know why? I expect to see we just ignore the hint, but it reports "can't resolve column", which is pretty weird. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
