[GitHub] [spark] dbtsai commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable

2020-03-04 Thread GitBox
dbtsai commented on issue #27778: [SPARK-31027] [SQL] Refactor 
DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594688462
 
 
   Also merged into 3.0 branch since it's just refactoring without introducing 
new feature. It will make code maintenance easier for 3.0 and future master. 
Thanks all for reviewing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dbtsai commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable

2020-03-03 Thread GitBox
dbtsai commented on issue #27778: [SPARK-31027] [SQL] Refactor 
DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594335106
 
 
   @HyukjinKwon @dongjoon-hyun @viirya @rdblue @cloud-fan 
   
   Some changes based on @HyukjinKwon 's suggestion to use extractor pattern 
have been done. Would like to have your final reviews. Thanks,


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dbtsai commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable

2020-03-03 Thread GitBox
dbtsai commented on issue #27778: [SPARK-31027] [SQL] Refactor 
DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594153195
 
 
   cc @dongjoon-hyun @gengliangwang @cloud-fan @rdblue 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org