[GitHub] [spark] dengziming commented on pull request #39388: [SPARK-41354][CONNECT][PYTHON] Implement RepartitionByExpression

2023-01-08 Thread GitBox 


dengziming commented on PR #39388:
URL: https://github.com/apache/spark/pull/39388#issuecomment-1375160517

   > @dengziming would you mind resolving the conflicts? thanks
   
   Done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dengziming commented on pull request #39388: [SPARK-41354][CONNECT][PYTHON] implement RepartitionByExpression

2023-01-04 Thread GitBox 


dengziming commented on PR #39388:
URL: https://github.com/apache/spark/pull/39388#issuecomment-1371775675

   > just to confirm, the proto `RepartitionByExpression 
repartition_by_expression = 27` can support both
   > 
   > `def repartition(self, *cols: "ColumnOrName")` `def 
repartitionByRange(self, *cols: "ColumnOrName")`
   
   Yes, you are right @zhengruifeng . Both `repartition(cols)` and 
`repartitionByRange(cols)` will be transformed to `RepartitionByExpression`, 
this can be seen in `Dataset.scala` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org