dongjoon-hyun commented on a change in pull request #25564:
[SPARK-28857][INFRA] Clean up the comments of PR template during merging
URL: https://github.com/apache/spark/pull/25564#discussion_r316983236
##########
File path: dev/merge_spark_pr.py
##########
@@ -495,7 +495,24 @@ def main():
else:
title = pr["title"]
- body = pr["body"]
+ modified_body = re.sub(re.compile(r'<!--[^>]*-->\n?', re.DOTALL), '',
pr["body"]).lstrip()
Review comment:
`lstrip()` is used to remove the first PR template comments and new lines.
`strip()` has false positive because it will modify all PR description (which
doesn't have comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
