[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26840: [SPARK-30038][SQL] DESCRIBE FUNCTION should do multi-catalog resolution
dongjoon-hyun commented on a change in pull request #26840: [SPARK-30038][SQL]
DESCRIBE FUNCTION should do multi-catalog resolution
URL: https://github.com/apache/spark/pull/26840#discussion_r356423436
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##
@@ -1799,6 +1799,18 @@ class DataSourceV2SQLSuite
}
}
+ test("DESCRIBE FUNCTION not valid v1 namespace") {
+val e = intercept[AnalysisException] {
+ sql(s"DESCRIBE FUNCTION testcat.ns1.ns2.fun")
Review comment:
`s"` -> `"`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26840: [SPARK-30038][SQL] DESCRIBE FUNCTION should do multi-catalog resolution
dongjoon-hyun commented on a change in pull request #26840: [SPARK-30038][SQL]
DESCRIBE FUNCTION should do multi-catalog resolution
URL: https://github.com/apache/spark/pull/26840#discussion_r356423491
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##
@@ -1799,6 +1799,18 @@ class DataSourceV2SQLSuite
}
}
+ test("DESCRIBE FUNCTION not valid v1 namespace") {
+val e = intercept[AnalysisException] {
+ sql(s"DESCRIBE FUNCTION testcat.ns1.ns2.fun")
+}
+assert(e.message.contains("DESCRIBE FUNCTION is only supported in v1
catalog"))
+
+val e1 = intercept[AnalysisException] {
+ sql(s"DESCRIBE FUNCTION default.ns1.ns2.fun")
Review comment:
`s"` -> `"`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26840: [SPARK-30038][SQL] DESCRIBE FUNCTION should do multi-catalog resolution
dongjoon-hyun commented on a change in pull request #26840: [SPARK-30038][SQL]
DESCRIBE FUNCTION should do multi-catalog resolution
URL: https://github.com/apache/spark/pull/26840#discussion_r356423053
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##
@@ -472,6 +472,19 @@ class ResolveSessionCatalog(
tableName.asTableIdentifier,
propertyKey)
+case DescribeFunctionStatement(CatalogAndIdentifierParts(catalog,
functionName), extended) =>
+ val functionIdentifier = if (isSessionCatalog(catalog)) {
+ functionName match {
Review comment:
? indentation from line 477 to 483?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
