[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26844: [SPARK-30211][INFRA] Switch python to python3 in make-distribution.sh
dongjoon-hyun commented on a change in pull request #26844: [SPARK-30211][INFRA] Switch python to python3 in make-distribution.sh URL: https://github.com/apache/spark/pull/26844#discussion_r356435745 ## File path: docs/building-spark.md ## @@ -66,7 +66,7 @@ with Maven profile settings and so on like the direct Maven build. Example: ./dev/make-distribution.sh --name custom-spark --pip --r --tgz -Psparkr -Phive -Phive-thriftserver -Pmesos -Pyarn -Pkubernetes -This will build Spark distribution along with Python pip and R packages. For more information on usage, run `./dev/make-distribution.sh --help` +This will build Spark distribution along with Python pip and R packages. (Note that build with Python pip package requires Python 3.6). For more information on usage, run `./dev/make-distribution.sh --help` Review comment: ~Ur, shall we revert this line since there is Python 3.7 and 3.8?~ Oops, Never mind. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26844: [SPARK-30211][INFRA] Switch python to python3 in make-distribution.sh
dongjoon-hyun commented on a change in pull request #26844: [SPARK-30211][INFRA] Switch python to python3 in make-distribution.sh URL: https://github.com/apache/spark/pull/26844#discussion_r356435745 ## File path: docs/building-spark.md ## @@ -66,7 +66,7 @@ with Maven profile settings and so on like the direct Maven build. Example: ./dev/make-distribution.sh --name custom-spark --pip --r --tgz -Psparkr -Phive -Phive-thriftserver -Pmesos -Pyarn -Pkubernetes -This will build Spark distribution along with Python pip and R packages. For more information on usage, run `./dev/make-distribution.sh --help` +This will build Spark distribution along with Python pip and R packages. (Note that build with Python pip package requires Python 3.6). For more information on usage, run `./dev/make-distribution.sh --help` Review comment: Ur, shall we revert this line since there is Python 3.7 and 3.8? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26844: [SPARK-30211][INFRA] Switch python to python3 in make-distribution.sh
dongjoon-hyun commented on a change in pull request #26844: [SPARK-30211][INFRA] Switch python to python3 in make-distribution.sh URL: https://github.com/apache/spark/pull/26844#discussion_r356387172 ## File path: dev/make-distribution.sh ## @@ -233,7 +233,7 @@ if [ "$MAKE_PIP" == "true" ]; then pushd "$SPARK_HOME/python" > /dev/null # Delete the egg info file if it exists, this can cache older setup files. rm -rf pyspark.egg-info || echo "No existing egg info file, skipping deletion" - python setup.py sdist + python3 setup.py sdist Review comment: Does this mean that `preview2` is the first PySpark distribution packaged by Python3? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26844: [SPARK-30211][INFRA] Switch python to python3 in make-distribution.sh
dongjoon-hyun commented on a change in pull request #26844: [SPARK-30211][INFRA] Switch python to python3 in make-distribution.sh URL: https://github.com/apache/spark/pull/26844#discussion_r356387043 ## File path: dev/make-distribution.sh ## @@ -233,7 +233,7 @@ if [ "$MAKE_PIP" == "true" ]; then pushd "$SPARK_HOME/python" > /dev/null # Delete the egg info file if it exists, this can cache older setup files. rm -rf pyspark.egg-info || echo "No existing egg info file, skipping deletion" - python setup.py sdist + python3 setup.py sdist Review comment: This looks good itself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
