dongjoon-hyun commented on a change in pull request #28077:
[SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark
applications
URL: https://github.com/apache/spark/pull/28077#discussion_r400634191
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -474,10 +474,12 @@ private[spark] class SparkSubmit extends Logging {
args.mainClass = "org.apache.spark.deploy.PythonRunner"
args.childArgs = ArrayBuffer(localPrimaryResource, localPyFiles) ++
args.childArgs
}
- if (clusterManager != YARN) {
- // The YARN backend handles python files differently, so don't merge
the lists.
- args.files = mergeFileLists(args.files, args.pyFiles)
- }
+ }
+
+ // Non-PySpark applications will also need Python dependencies.
+ if (deployMode == CLIENT && clusterManager != YARN) {
Review comment:
Just a question. Did we `mergeFileLists` for `deployMode != CLIENT` already?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
