[GitHub] [spark] dongjoon-hyun commented on issue #24092: [SPARK-27160][SQL] Fix DecimalType literal casting

2019-03-14 Thread GitBox
dongjoon-hyun commented on issue #24092: [SPARK-27160][SQL] Fix DecimalType 
literal casting
URL: https://github.com/apache/spark/pull/24092#issuecomment-473145953
 
 
   Yes, right, @sadhen .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #24092: [SPARK-27160][SQL] Fix DecimalType literal casting

2019-03-14 Thread GitBox
dongjoon-hyun commented on issue #24092: [SPARK-27160][SQL] Fix DecimalType 
literal casting
URL: https://github.com/apache/spark/pull/24092#issuecomment-473138559
 
 
   +1 for @cloud-fan 's opinion.
   @sadhen , could you add another test case for that?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #24092: [SPARK-27160][SQL] Fix DecimalType literal casting

2019-03-14 Thread GitBox
dongjoon-hyun commented on issue #24092: [SPARK-27160][SQL] Fix DecimalType 
literal casting
URL: https://github.com/apache/spark/pull/24092#issuecomment-473090917
 
 
   cc @dbtsai since he is a release manager.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #24092: [SPARK-27160][SQL] Fix DecimalType literal casting

2019-03-14 Thread GitBox
dongjoon-hyun commented on issue #24092: [SPARK-27160][SQL] Fix DecimalType 
literal casting
URL: https://github.com/apache/spark/pull/24092#issuecomment-473078757
 
 
   Retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #24092: [SPARK-27160][SQL] Fix DecimalType literal casting

2019-03-14 Thread GitBox
dongjoon-hyun commented on issue #24092: [SPARK-27160][SQL] Fix DecimalType 
literal casting
URL: https://github.com/apache/spark/pull/24092#issuecomment-473077205
 
 
   Thank you for pinging me, @sadhen . I'll take a look today!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org