[GitHub] [spark] dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-18 Thread GitBox
dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion 
to accept JDK8+
URL: https://github.com/apache/spark/pull/25472#issuecomment-522428677
 
 
   Thank you, @felixcheung ! Got it. 
   - For `paste`, I'll do follow up .
   - For `SystemRequirements: Java (>= 8)`, I'll revisit this in this week 
after the `master` branch starts to support `JDK11` officially~


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion 
to accept JDK8+
URL: https://github.com/apache/spark/pull/25472#issuecomment-522080459
 
 
   Thank you, @HyukjinKwon and @srowen . 
   Merged to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion 
to accept JDK8+
URL: https://github.com/apache/spark/pull/25472#issuecomment-522056548
 
 
   Retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion 
to accept JDK8+
URL: https://github.com/apache/spark/pull/25472#issuecomment-521977333
 
 
   Retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion 
to accept JDK8+
URL: https://github.com/apache/spark/pull/25472#issuecomment-521956693
 
 
   Thank you for review, @HyukjinKwon . I updated the PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion to accept JDK8+

2019-08-16 Thread GitBox
dongjoon-hyun commented on issue #25472: [SPARK-28756][R] Fix checkJavaVersion 
to accept JDK8+
URL: https://github.com/apache/spark/pull/25472#issuecomment-521936732
 
 
   Hi, @HyukjinKwon , @srowen , @felixcheung .
   Could you review this PR for JDK11 support?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org