[GitHub] [spark] dongjoon-hyun commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern

2019-09-19 Thread GitBox
dongjoon-hyun commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use 
`tryWithResource` pattern
URL: https://github.com/apache/spark/pull/25842#issuecomment-52655
 
 
   Thank you, @HyukjinKwon , @srowen , @HeartSaVioR . Merged to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern

2019-09-19 Thread GitBox
dongjoon-hyun commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use 
`tryWithResource` pattern
URL: https://github.com/apache/spark/pull/25842#issuecomment-533005826
 
 
   Retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern

2019-09-18 Thread GitBox
dongjoon-hyun commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use 
`tryWithResource` pattern
URL: https://github.com/apache/spark/pull/25842#issuecomment-532968870
 
 
   Thank you for review. I transformed the test cases, too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use `tryWithResource` pattern

2019-09-18 Thread GitBox
dongjoon-hyun commented on issue #25842: [SPARK-28208][SQL][FOLLOWUP] Use 
`tryWithResource` pattern
URL: https://github.com/apache/spark/pull/25842#issuecomment-532947931
 
 
   cc @HyukjinKwon 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org