[GitHub] [spark] dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-579486937 Sorry, but it doesn't address my concerns. > Please check updated description and let me know if that addresses your concerns. https://user-images.githubusercontent.com/9700541/73310146-82b71780-41d8-11ea-8db7-2662bfb544a7.png";> I ask you the following. In the above, I cannot see the following content. Even, you completely hide the word `arrow`. > "In the PR description, write that you didn't run the full test. Especially Arrow tests are skipped". It was my request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578601545 ? @zero323 . It seems that you missed my point. I advised like the following. > I'd like to recommend you to mention what you've done clearly. That's enough. Let me rephrase my words. "In the PR description, write that you didn't run the full test. Especially Arrow tests are skipped". It was my request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578573228 We cannot say `We're good` when we know something wrong. I'd like to recommend you to mention what you've done clearly. That's enough. Please note that I'm supporting your effort on this PR. Otherwise, I'll not chim in here to add comments. > So skipped Arrow tests are expected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578569365 @zero323 . Thank you for the screencast. However, it skipped all arrow related tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0
dongjoon-hyun commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578473355 @zero323 . Please update the PR description. For example, the followings? ``` Disables unit tests for faulty code (SPARK-30629) Modify Unicode handling test case to be handled properly independent of OS. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
