[GitHub] [spark] dongjoon-hyun commented on pull request #29142: [SPARK-32360][SQL] Add MaxMinBy to support eliminate sorts

[GitBox]

dongjoon-hyun commented on pull request #29142:
URL: https://github.com/apache/spark/pull/29142#issuecomment-661618176


   cc @gatorsmile 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #29142: [SPARK-32360][SQL] Add MaxMinBy to support eliminate sorts

[GitBox]

dongjoon-hyun commented on pull request #29142:
URL: https://github.com/apache/spark/pull/29142#issuecomment-661517034


   Thank you, @ulysses-you .



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #29142: [SPARK-32360][SQL] Add MaxMinBy to support eliminate sorts

[GitBox]

dongjoon-hyun commented on pull request #29142:
URL: https://github.com/apache/spark/pull/29142#issuecomment-661336084


   Could you close this PR, @ulysses-you ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #29142: [SPARK-32360][SQL] Add MaxMinBy to support eliminate sorts

[GitBox]

dongjoon-hyun commented on pull request #29142:
URL: https://github.com/apache/spark/pull/29142#issuecomment-660774475


   Thank you for your update. Could you fix the UT failure? The newly add UT is 
failing now.
   ```
   [info] - SPARK-32360: Add MaxMinBy to support eliminate sorts *** FAILED *** 
(7 milliseconds)
   [info]   org.apache.spark.sql.AnalysisException: expression '`b`' is neither 
present in the group by, nor is it an aggregate function. Add to group by or 
wrap in first() (or first_value) if you don't care which value you get.;
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org