[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28830: [SPARK-31990][SS] Preserves the input order of colNames in dropDuplicates

2020-06-14 Thread GitBox


dongjoon-hyun edited a comment on pull request #28830:
URL: https://github.com/apache/spark/pull/28830#issuecomment-643878606


   Hi, All.
   This issue is marked as a hotfix for the blocker issue, but the validation 
of this issue looks non-trivial. Since `toSet.toSeq` is used since Apache Spark 
2.2.0 (SPARK-19497) and SPARK-31292 is just an `Improvement` issue with 
`Trivial` priority. I'd like to propose to revert SPARK-31292 from `branch-3.0` 
first. We will keep SPARK-31292 in `master` branch still and proceed this 
@maropu 's PR to find a better way for Apache Spark 3.1.0.
   
   I know that the reverting is not a good solution for the original author as 
mentioned by @HeartSaVioR in the dev mailing list, but I believe that is the 
proper way in this case to cut Apache Spark 3.0.1. How do you think about that?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28830: [SPARK-31990][SS] Preserves the input order of colNames in dropDuplicates

2020-06-14 Thread GitBox


dongjoon-hyun edited a comment on pull request #28830:
URL: https://github.com/apache/spark/pull/28830#issuecomment-643878606







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org