[GitHub] [spark] erenavsarogullari edited a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API
erenavsarogullari edited a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-625574953 Also, i think this PR can be useful for the community if it can be covered by `v3.0.0` (current jira affects version points `v3.1.0`). Users can start to use this version directly. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] erenavsarogullari edited a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API
erenavsarogullari edited a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-625574953 Also, i think this PR can be useful for the community if it can be covered by `v3.0.0` (current jira affects version points `v3.1.0`). WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] erenavsarogullari edited a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API
erenavsarogullari edited a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-625569721 > > @gengliangwang There is optional Http parameter: details (default: false). It needs to be set in order to fetch node, edge and planDescription details as well: > > http://localhost:4040/api/v1/applications//sql/0?details=true > > I tried again and I can see them now. Thanks for pointing it out. > How about showing the details by default? Users might not be aware of the option. @gengliangwang Yes, it makes sense and set `details` Http parameter `true` as default by the last patch and if the end-user needs, both `details` and/or `planDescription` can be disabled as follows: `../sql?details=false=false` or `../sql/0?details=false=false` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] erenavsarogullari edited a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API
erenavsarogullari edited a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-625569721 > > @gengliangwang There is optional Http parameter: details (default: false). It needs to be set in order to fetch node, edge and planDescription details as well: > > http://localhost:4040/api/v1/applications//sql/0?details=true > > I tried again and I can see them now. Thanks for pointing it out. > How about showing the details by default? Users might not be aware of the option. @gengliangwang Yes, it makes sense and set `details` Http parameter `true` as default by the last patch and if the end-user needs, can be disabled as follows: `../sql?details=false=false` or `../sql/0?details=false=false` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] erenavsarogullari edited a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API
erenavsarogullari edited a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-625569721 > > @gengliangwang There is optional Http parameter: details (default: false). It needs to be set in order to fetch node, edge and planDescription details as well: > > http://localhost:4040/api/v1/applications//sql/0?details=true > > I tried again and I can see them now. Thanks for pointing it out. > How about showing the details by default? Users might not be aware of the option. @gengliangwang Yes, it makes sense and set `details` Http parameter `true` as default by the last patch and if the end-user needs, can be disabled as `../sql/0?details=false=false` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] erenavsarogullari edited a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API
erenavsarogullari edited a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-625569721 > > @gengliangwang There is optional Http parameter: details (default: false). It needs to be set in order to fetch node, edge and planDescription details as well: > > http://localhost:4040/api/v1/applications//sql/0?details=true > > I tried again and I can see them now. Thanks for pointing it out. > How about showing the details by default? Users might not be aware of the option. @gengliangwang Yes, it makes sense and set `details` Http parameter `true` as default by the last patch and if the end-user needs, can be disabled as follows: `../sql/0?details=false=false` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] erenavsarogullari edited a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API
erenavsarogullari edited a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-625569445 > > @gengliangwang There is optional Http parameter: details (default: false). It needs to be set in order to fetch node, edge and planDescription details as well: > > http://localhost:4040/api/v1/applications//sql/0?details=true > > I tried again and I can see them now. Thanks for pointing it out. > How about showing the details by default? Users might not be aware of the option. @gengliangwang Yes, it makes sense and set `details` Http parameter `true` as default by the last patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] erenavsarogullari edited a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API
erenavsarogullari edited a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-624435102 @gengliangwang There is optional Http parameter: `details` (default: `false`). It needs to be set in order to fetch `node`, `edge` and `planDescription` details as well: `http://localhost:4040/api/v1/applications//sql/0?details=true` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] erenavsarogullari edited a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API
erenavsarogullari edited a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-622683515 Hi @gengliangwang, Thanks one more time for the review. 1- Added `edges` support, 2- Renamed `metricsDetails` as `nodes`, 3- Details are being computed if `details=true`. Please find latest json result as follows: https://issues.apache.org/jira/secure/attachment/13001866/improved_version_May1th.json This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] erenavsarogullari edited a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API
erenavsarogullari edited a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-619658674 Hi @gengliangwang, Thanks again for the review. Currently, all `nodes` are being listed where `edges` infos as previous attached screenshot. Please let me know if you have any concern with current way. Also, i created documentation for SQL Rest API - PR: #28354 as the follow-up for this work. Just fyi. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
