[GitHub] [spark] holdenk commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor
holdenk commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662808939 Merged, thanks everyone. I don't know if we have a good principle around naming host v. worker with the deprecation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor
holdenk commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662790280 Cool I’ll try merge this after dinner, thanks everyone for working on and reviewing this 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor
holdenk commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662171821 Thanks for the updates @agrawaldevesh. This looks good to me. I don't see any pending conversations that are ongoing, so if no one has any concerns that they aren't ok carrying through to the follow on PR that you've already got open, I plan to merge this tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor
holdenk commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662169138 The pyspark packaging tests have generally been flaky so i think we don't have to worry about them given that the GH actions all passed. Let me do another pass through reveiw, although it looks like it's already got one approval :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
