[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve
tooltip for Streaming tab
URL: https://github.com/apache/spark/pull/26467#discussion_r352995040
##
File path:
streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala
##
@@ -162,7 +163,7 @@ class UISeleniumSuite
outputOpIds.map(_.text) should be (List("0", "1"))
// Check job ids
-val jobIdCells = findAll(cssSelector( """#batch-job-table a""")).toSeq
+val jobIdCells = findAll(cssSelector( """#jobId""")).toSeq
Review comment:
Ok, i understand. Now, i have removed all the user facing changes and added
a filter to filter out the jobIds. I guess this will be fine.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve
tooltip for Streaming tab
URL: https://github.com/apache/spark/pull/26467#discussion_r352757120
##
File path:
streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala
##
@@ -162,7 +163,7 @@ class UISeleniumSuite
outputOpIds.map(_.text) should be (List("0", "1"))
// Check job ids
-val jobIdCells = findAll(cssSelector( """#batch-job-table a""")).toSeq
+val jobIdCells = findAll(cssSelector( """#jobId""")).toSeq
Review comment:
added "class" instead of "id" for the Job Ids. Please retest.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve
tooltip for Streaming tab
URL: https://github.com/apache/spark/pull/26467#discussion_r352740785
##
File path:
streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala
##
@@ -162,7 +163,7 @@ class UISeleniumSuite
outputOpIds.map(_.text) should be (List("0", "1"))
// Check job ids
-val jobIdCells = findAll(cssSelector( """#batch-job-table a""")).toSeq
+val jobIdCells = findAll(cssSelector( """#jobId""")).toSeq
Review comment:
since here we are testing for jobids only, may be its better to add unique
tag to identify them. and this also make sure we are getting jobIds only.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve
tooltip for Streaming tab
URL: https://github.com/apache/spark/pull/26467#discussion_r352740785
##
File path:
streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala
##
@@ -162,7 +163,7 @@ class UISeleniumSuite
outputOpIds.map(_.text) should be (List("0", "1"))
// Check job ids
-val jobIdCells = findAll(cssSelector( """#batch-job-table a""")).toSeq
+val jobIdCells = findAll(cssSelector( """#jobId""")).toSeq
Review comment:
since here we are testing for jobids only, may be its better to add unique
tag to identify them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve
tooltip for Streaming tab
URL: https://github.com/apache/spark/pull/26467#discussion_r352474370
##
File path:
streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala
##
@@ -163,7 +164,7 @@ class UISeleniumSuite
// Check job ids
val jobIdCells = findAll(cssSelector( """#batch-job-table a""")).toSeq
-jobIdCells.map(_.text) should be (List("0", "1", "2", "3"))
+jobIdCells.map(_.text) should be (List("?", "?", "0", "1", "2", "3"))
Review comment:
Modified the test case to only check for "jobId". Please review and retest.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve
tooltip for Streaming tab
URL: https://github.com/apache/spark/pull/26467#discussion_r351986143
##
File path:
streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala
##
@@ -163,7 +164,7 @@ class UISeleniumSuite
// Check job ids
val jobIdCells = findAll(cssSelector( """#batch-job-table a""")).toSeq
-jobIdCells.map(_.text) should be (List("0", "1", "2", "3"))
+jobIdCells.map(_.text) should be (List("?", "?", "0", "1", "2", "3"))
Review comment:
Tooltips are defined with hyperlink tag in UIUtils.scala. And in this case
we are also searching for all the hyperlinks in the table 'batch-job-table'.
That's why "?" is required here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve
tooltip for Streaming tab
URL: https://github.com/apache/spark/pull/26467#discussion_r351825474
##
File path:
streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala
##
@@ -151,8 +151,9 @@ class UISeleniumSuite
summaryText should contain ("Total delay:")
findAll(cssSelector("""#batch-job-table th""")).map(_.text).toSeq
should be {
- List("Output Op Id", "Description", "Output Op Duration", "Status",
"Job Id",
-"Job Duration", "Stages: Succeeded/Total", "Tasks (for all
stages): Succeeded/Total",
+ List("Output Op Id", "Description", "Output Op Duration (?)",
"Status", "Job Id",
Review comment:
"(?)" is superscript for Output Op Duration and Job Duration. This
superscript got added when adding the tooltip. The same convention is followed
for each page of streaming tab.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve
tooltip for Streaming tab
URL: https://github.com/apache/spark/pull/26467#discussion_r351601698
##
File path:
streaming/src/main/scala/org/apache/spark/streaming/ui/BatchPage.scala
##
@@ -37,10 +37,14 @@ private[ui] class BatchPage(parent: StreamingTab) extends
WebUIPage("batch") {
private def columns: Seq[Node] = {
Output Op Id
Description
- Output Op Duration
+ Output Op Duration {SparkUIUtils.tooltip("Time taken for all the
jobs of this batch to" +
Review comment:
Output Op duration is the time taken for all the jobs of that batch to
finish processing from the time they were submitted. So it gives scheduling
delay(time to schedule first job of the batch) + processing delay(time from
start of processing of first job till the end of processing of last job of
batch).
While job duration gives detail about a single job, Output Op duration gives
info about the entire batch.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on a change in pull request #26467: [SPARK-29477]Improve tooltip for Streaming tab
iRakson commented on a change in pull request #26467: [SPARK-29477]Improve
tooltip for Streaming tab
URL: https://github.com/apache/spark/pull/26467#discussion_r345028095
##
File path:
streaming/src/main/scala/org/apache/spark/streaming/ui/BatchPage.scala
##
@@ -37,10 +37,11 @@ private[ui] class BatchPage(parent: StreamingTab) extends
WebUIPage("batch") {
private def columns: Seq[Node] = {
Output Op Id
Description
- Output Op Duration
+ Output Op Duration {SparkUIUtils.tooltip("Time taken to handle all
jobs of the batch",
Review comment:
we should show the exact start time and end time of the job as tooltip? Or,
do we need to define the start and end time here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
