[GitHub] [spark] iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab
iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab URL: https://github.com/apache/spark/pull/26756#issuecomment-565777004 cc @srowen @shahidki31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab
iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab URL: https://github.com/apache/spark/pull/26756#issuecomment-565776985 I have added pagination support for completed batch table as well as active batch table in streaming tab. For both the tables there is one common class which will be used for creating both the tables. This eliminates the duplication of code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab
iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab URL: https://github.com/apache/spark/pull/26756#issuecomment-563166152 At this moment i have not added pagination support for active batches. Now i will add that in this PR only. This will help us preventing code duplication as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab
iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab URL: https://github.com/apache/spark/pull/26756#issuecomment-563159937 @shahidki31 all the methods that you mentioned are part of abstract class `BatchTableBase`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab
iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab URL: https://github.com/apache/spark/pull/26756#issuecomment-561978199 I will push with all the changes in few minutes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab
iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab URL: https://github.com/apache/spark/pull/26756#issuecomment-561970920 cc @shahidki31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab
iRakson commented on issue #26756: [SPARK-30119][WebUI]Support Pagination for Completed Batch Table in Streaming Tab URL: https://github.com/apache/spark/pull/26756#issuecomment-561526619 Please review @srowen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
