[GitHub] [spark] jzhuge commented on pull request #37556: [SPARK-39799][SQL] DataSourceV2: View catalog interface

2022-11-16 Thread GitBox


jzhuge commented on PR #37556:
URL: https://github.com/apache/spark/pull/37556#issuecomment-1317402205

   Thanks @holdenk, @wmoustafa, @xkrogen, @ljfgem for the reviews!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] jzhuge commented on pull request #37556: [SPARK-39799][SQL] DataSourceV2: View catalog interface

2022-11-07 Thread GitBox


jzhuge commented on PR #37556:
URL: https://github.com/apache/spark/pull/37556#issuecomment-1306034903

   > Looking at error:
   > 
   > ```
   > SparkThrowableSuite.Error classes are correctly formatted
   > ```
   
   Fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] jzhuge commented on pull request #37556: [SPARK-39799][SQL] DataSourceV2: View catalog interface

2022-11-05 Thread GitBox


jzhuge commented on PR #37556:
URL: https://github.com/apache/spark/pull/37556#issuecomment-1304612855

   Puzzled by this pyspark test failures. Seems unrelated.
   ```
   [info] compiling 25 Scala sources to 
/__w/spark/spark/connector/docker-integration-tests/target/scala-2.12/test-classes
 ...
   [error] 
/__w/spark/spark/sql/hive/src/test/scala/org/apache/spark/sql/HiveCharVarcharTestSuite.scala:49:13:
 exception during macro expansion: 
   [error] java.util.MissingResourceException: Can't find bundle for base name 
org.scalactic.ScalacticBundle, locale en_US
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] jzhuge commented on pull request #37556: [SPARK-39799][SQL] DataSourceV2: View catalog interface

2022-11-02 Thread GitBox


jzhuge commented on PR #37556:
URL: https://github.com/apache/spark/pull/37556#issuecomment-1301598157

   Looking at error:
   ```
   SparkThrowableSuite.Error classes are correctly formatted
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] jzhuge commented on pull request #37556: [SPARK-39799][SQL] DataSourceV2: View catalog interface

2022-08-18 Thread GitBox


jzhuge commented on PR #37556:
URL: https://github.com/apache/spark/pull/37556#issuecomment-1219900964

   Find this message strange from 
https://github.com/jzhuge/spark/runs/7886846067?check_suite_focus=true:
   ```
   [info] Found the following changed modules: catalyst, hive-thriftserver
   ```
   This PR does not change module `hive-thriftserver`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org