[GitHub] [spark] maropu commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-23 Thread GitBox
maropu commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle 
"NOT IN" condition when using "JOIN"   
URL: https://github.com/apache/spark/pull/25854#issuecomment-545745432
 
 
   Can you update the title? `Support sub-queries in join conditions`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-22 Thread GitBox
maropu commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle 
"NOT IN" condition when using "JOIN"
URL: https://github.com/apache/spark/pull/25854#issuecomment-545277306
 
 
   yea, ok.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-22 Thread GitBox
maropu commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle 
"NOT IN" condition when using "JOIN"
URL: https://github.com/apache/spark/pull/25854#issuecomment-545256959
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-09-19 Thread GitBox
maropu commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle 
"NOT IN" condition when using "JOIN"
URL: https://github.com/apache/spark/pull/25854#issuecomment-533361041
 
 
   Also, can you add end-to-end tests in `SQLQueryTestSuite` or somewhere?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] maropu commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-09-19 Thread GitBox
maropu commented on issue #25854: [SPARK-29145][SQL]Spark SQL cannot handle 
"NOT IN" condition when using "JOIN"
URL: https://github.com/apache/spark/pull/25854#issuecomment-533360935
 
 
   > Does this PR introduce any user-facing change?
   
   No? It seems ths pr intends to accept a new statement in DataFrame/SQL?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org