[GitHub] [spark] maropu commented on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message
maropu commented on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-656926593 > For me , I prefer more clear information let user know it's wrong form super.makeExpressionFunction. and But, the relationship of `1.` and `2.` looks ambiguous to me. Does the message mean that there are two reasons for the failure? Could you brush up the message more? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message
maropu commented on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-656603797 > 1. Make Expression failed in SessionCatalog for function name = longProductSum: Invalid number of arguments for function longProductSum. Expected: 2; Found: 1; > 2. No handler for UDF/UDAF/UDTF 'org.apache.spark.sql.hive.execution.LongProductSum'; line 1 pos 7 We need the number `1` and `2`? How about reformatting it like this? ``` No handler for UDF/UDAF/UDTF 'org.apache.spark.sql.hive.execution.LongProductSum' because; Invalid number of arguments for function longProductSum ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message
maropu commented on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-656490867 Please describe exception messages before/after this PR in the description. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
