moomindani opened a new pull request #28953:
URL: https://github.com/apache/spark/pull/28953


   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section 
is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster 
reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class 
hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other 
DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   This pull request is to support query execution before/after reading/writing 
over JDBC.
   There are two new options; `preActions` and `postActions` in DataFrame's 
JDBC configuration.
   
   SQL statements specified in `preActions` will be executed before 
reading/writing DataFrame via JDBC.
   SQL statements specified in `postActions` will be executed after writing 
DataFrame via JDBC.
   
   Note: `postActions` is only supported in JDBC writer, not in JDBC reader. It 
is because it won't be needed so often and I was not able to find good places 
to implement this.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   For ETL workload, there is a common requirement to perform SQL statement 
before/after reading/writing over JDBC.
   Here's examples;
   - Create a view with specific conditions
   - Delete/Update some records
   - Truncate a table (it is already possible in `truncate` option)
   - Execute stored procedure (it is also requested in SPARK-32014)
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   Yes.
   With this feature, users can run any SQL statements before/after 
reading/writing DataFrame over JDBC.
   
   It does not affect any existing behavior. It just adds new options to use 
this new feature.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   -->
   
   I added test cases into `JDBCSuite.scala` and `JDBCWriteSuite.scala`, and 
confirmed all the tests have been passed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to