[GitHub] [spark] mridulm commented on a change in pull request #32564: [SPARK-35416][K8S] Support PersistentVolumeClaim Reuse

2021-06-02 Thread GitBox 


mridulm commented on a change in pull request #32564:
URL: https://github.com/apache/spark/pull/32564#discussion_r644195537



##
File path: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
##
@@ -357,6 +387,36 @@ private[spark] class ExecutorPodsAllocator(
 }
   }
 
+  private def replacePVCsIfNeeded(
+  pod: Pod,
+  resources: Seq[HasMetadata],
+  reusablePVCs: mutable.Buffer[PersistentVolumeClaim]) = {
+val replacedResources = mutable.ArrayBuffer[HasMetadata]()

Review comment:
   The only use of `replacedResources` is to do a `filterNot` on 
`resources` in this method - right ?
   So whether unique or not does not matter ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] mridulm commented on a change in pull request #32564: [SPARK-35416][K8S] Support PersistentVolumeClaim Reuse

2021-06-01 Thread GitBox 


mridulm commented on a change in pull request #32564:
URL: https://github.com/apache/spark/pull/32564#discussion_r643636239



##
File path: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
##
@@ -357,6 +387,36 @@ private[spark] class ExecutorPodsAllocator(
 }
   }
 
+  private def replacePVCsIfNeeded(
+  pod: Pod,
+  resources: Seq[HasMetadata],
+  reusablePVCs: mutable.Buffer[PersistentVolumeClaim]) = {
+val replacedResources = mutable.ArrayBuffer[HasMetadata]()

Review comment:
   Set instead ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] mridulm commented on a change in pull request #32564: [SPARK-35416][K8S] Support PersistentVolumeClaim Reuse

2021-06-01 Thread GitBox 


mridulm commented on a change in pull request #32564:
URL: https://github.com/apache/spark/pull/32564#discussion_r643635908



##
File path: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
##
@@ -357,6 +387,36 @@ private[spark] class ExecutorPodsAllocator(
 }
   }
 
+  private def replacePVCsIfNeeded(
+  pod: Pod,
+  resources: Seq[HasMetadata],
+  reusablePVCs: mutable.Buffer[PersistentVolumeClaim]) = {

Review comment:
   nit: Add return type




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org