[GitHub] [spark] prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager
prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager URL: https://github.com/apache/spark/pull/27539#issuecomment-588066491 @Ngone51 @cloud-fan Can you please review and merge the changes if everything looks good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager
prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager URL: https://github.com/apache/spark/pull/27539#issuecomment-588066239 > @prakharjain09 actually, you could also try "Jenkins, retest this please" when you want to re-trigger the test. As per https://spark.apache.org/contributing.html page, a Committer has to add me to whitelist using "Jenkins, add to whitelist" :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager
prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager URL: https://github.com/apache/spark/pull/27539#issuecomment-587437251 > **[Test build #118610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118610/testReport)** for PR 27539 at commit [`91e3a36`](https://github.com/apache/spark/commit/91e3a360f061546ef172a994b60a736baa1ea7d9). > > * This patch **fails due to an unknown error code, -9**. > * This patch merges cleanly. > * This patch adds no public classes. Looks like some different intermittent failure - not a test failure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager
prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager URL: https://github.com/apache/spark/pull/27539#issuecomment-586982776 > **[Test build #118566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118566/testReport)** for PR 27539 at commit [`4857401`](https://github.com/apache/spark/commit/48574017b43073c58d718d8f7f2c3d8e05d2fa24). > > * This patch **fails Spark unit tests**. > * This patch merges cleanly. > * This patch adds no public classes. @Ngone51 Test failures unrelated to this change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager
prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager URL: https://github.com/apache/spark/pull/27539#issuecomment-586909724 @Ngone51 @cloud-fan I have fixed the flaky test. In the last 2-3 test builds, failures are not due to changes in this PR. Can you please review the new test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager
prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager URL: https://github.com/apache/spark/pull/27539#issuecomment-586095859 @cloud-fan @Ngone51 Thanks for reviewing the PR. The UT added in this PR always passes on my machine but on jenkins machine - it sometimes passes and sometimes fails. Could you please help take a look on the intermittent failure. Parallely I am also trying to replace the low memory BlockManagers in my test with some mocked objects to avoid flakiness. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager
prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager URL: https://github.com/apache/spark/pull/27539#issuecomment-585091522 Jenkins, retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
