techaddict commented on PR #39393: URL: https://github.com/apache/spark/pull/39393#issuecomment-1371689457
@HyukjinKwon After spending some time with this, looks like the change is much bigger Proto Message Hint expected parameters to be repeated literal https://github.com/apache/spark/blob/master/connector/connect/common/src/main/protobuf/spark/connect/relations.proto#L698-L710 adding list to this would require more changes in proto definition, I'm not super familiar with proto3, but it doesn't support extending and we can't do repeated oneof either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
