[GitHub] [spark] viirya commented on a change in pull request #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions
viirya commented on a change in pull request #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions URL: https://github.com/apache/spark/pull/26441#discussion_r344474408 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -949,14 +949,19 @@ class Analyzer( if oldVersion.outputSet.intersect(conflictingAttributes).nonEmpty => (oldVersion, oldVersion.copy(serializer = oldVersion.serializer.map(_.newInstance( -// Handle projects that create conflicting aliases. case oldVersion @ Project(projectList, _) -if findAliases(projectList).intersect(conflictingAttributes).nonEmpty => Review comment: I am not sure why we only process aliases previously. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions
viirya commented on a change in pull request #26441: [SPARK-29682][SQL] Resolve conflicting references in aggregate expressions URL: https://github.com/apache/spark/pull/26441#discussion_r344415910 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -951,12 +951,15 @@ class Analyzer( // Handle projects that create conflicting aliases. case oldVersion @ Project(projectList, _) -if findAliases(projectList).intersect(conflictingAttributes).nonEmpty => +if hasConflictInAlias(projectList, conflictingAttributes) => Review comment: Can project also use `hasConflict`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
