[GitHub] [spark] yaooqinn commented on a change in pull request #32718: [SPARK-21957][SQL] Support current_user and session_user functions

[GitBox]

yaooqinn commented on a change in pull request #32718:
URL: https://github.com/apache/spark/pull/32718#discussion_r642906142



##
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
##
@@ -283,3 +283,21 @@ case class TypeOf(child: Expression) extends 
UnaryExpression {
 
   override protected def withNewChildInternal(newChild: Expression): TypeOf = 
copy(child = newChild)
 }
+
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+  usage = """_FUNC_() - Return the current user who is running SparkContext 
for current query execution.""",

Review comment:
   right




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] yaooqinn commented on a change in pull request #32718: [SPARK-21957][SQL] Support current_user and session_user functions

[GitBox]

yaooqinn commented on a change in pull request #32718:
URL: https://github.com/apache/spark/pull/32718#discussion_r642796052



##
File path: sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala
##
@@ -40,6 +40,12 @@ class MiscFunctionsSuite extends QueryTest with 
SharedSparkSession {
   Row(SPARK_VERSION_SHORT + " " + SPARK_REVISION))
 assert(df.schema.fieldNames === Seq("version()"))
   }
+
+  test("get current_user and session_user in normal spark apps") {

Review comment:
   my bad, I forgot it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org