[GitHub] [spark] yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support

2020-04-20 Thread GitBox


yaooqinn commented on issue #28106:
URL: https://github.com/apache/spark/pull/28106#issuecomment-616379269


   any change for this to go further? @maropu thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support

2020-04-15 Thread GitBox
yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support
URL: https://github.com/apache/spark/pull/28106#issuecomment-614018798
 
 
   updated in the pr description. maybe it's not a good idea to add such links 
to SQL document?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support

2020-04-14 Thread GitBox
yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support
URL: https://github.com/apache/spark/pull/28106#issuecomment-613259627
 
 
   retest this please
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support

2020-04-13 Thread GitBox
yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support
URL: https://github.com/apache/spark/pull/28106#issuecomment-613234916
 
 
   updated, Thank you very much @maropu 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support

2020-04-13 Thread GitBox
yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support
URL: https://github.com/apache/spark/pull/28106#issuecomment-613220617
 
 
   retest this please
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support

2020-04-13 Thread GitBox
yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support
URL: https://github.com/apache/spark/pull/28106#issuecomment-613164642
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support

2020-04-13 Thread GitBox
yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support
URL: https://github.com/apache/spark/pull/28106#issuecomment-612771291
 
 
   > How about allowing users to specify behavior (e.g., `try(expr, 
catchExpr)`) when exceptions occur instead of always returning null?
   
   Seems to make it more complicated, this is also supported by teradata/presto 
for one argument


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support

2020-04-12 Thread GitBox
yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support
URL: https://github.com/apache/spark/pull/28106#issuecomment-612722053
 
 
@cloud-fan @HyukjinKwon @maropu, now this function only suppresses
   ```IllegalArgumentException | ArithmeticException | DateTimeException | 
NumberFormatException | UnsupportedEncodingException```, Can you guys take a 
look again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support

2020-04-03 Thread GitBox
yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support
URL: https://github.com/apache/spark/pull/28106#issuecomment-608324347
 
 
   > interesting. So this will suppress all runtime exceptions but result to 
`null` instead?
   
   yes @HyukjinKwon 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support

2020-04-03 Thread GitBox
yaooqinn commented on issue #28106: [SPARK-31335][SQL] Add try function support
URL: https://github.com/apache/spark/pull/28106#issuecomment-608285759
 
 
   cc @cloud-fan @maropu @dongjoon-hyun @HyukjinKwon, thanks very much for 
review


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org