[GitHub] [spark] younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …
younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513214511 I thought we need to make the test cases work with UDFs as the original SQL spits out the following errors so I added 'ORDER BY' clause on it. **Window function row_number() requires window to be ordered, please add ORDER BY clause. For example SELECT row_number()(value_expr) OVER (PARTITION BY window_partition ORDER BY window_ordering) from table;** But I now understand the purpose of this work and think we should put it back to the original one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …
younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513214511 I thought we need to make the test cases work with UDFs as the original SQL spits out the following errors so I added 'ORDER BY' clause on it. **Window function row_number() requires window to be ordered, please add ORDER BY clause. For example SELECT row_number()(value_expr) OVER (PARTITION BY window_partition ORDER BY window_ordering) from table;** But I now understand the purpose of this work so I think we should put it back to the original one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …
younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513214511 I thought we need to make the test cases work with UDFs as the original SQL spits out the following errors so I added 'ORDER BY' clause on it: **Window function row_number() requires window to be ordered, please add ORDER BY clause. For example SELECT row_number()(value_expr) OVER (PARTITION BY window_partition ORDER BY window_ordering) from table;** But I now understand the purpose of this work so I think we should put it back to the original one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …
younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513214511 I thought we need to make the test cases work with UDFs as the original SQL spits out the following errors and I added 'ORDER BY' clause on it: **Window function row_number() requires window to be ordered, please add ORDER BY clause. For example SELECT row_number()(value_expr) OVER (PARTITION BY window_partition ORDER BY window_ordering) from table;** But I now understand the purpose of this work so I think we should put it back to the original one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …
younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513079590 @HyukjinKwon The reason is that I specified "ORDER BY val"?: Before: `SELECT val, cate, row_number() OVER(PARTITION BY cate) FROM testData ORDER BY cate, val;` After: `SELECT udf(val), cate, row_number() OVER(PARTITION BY cate ORDER BY val) FROM testData ORDER BY cate, udf(val)` I guess we shouldn't specify "ORDER BY val" here right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …
younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513079590 @HyukjinKwon The reason is that I specified the "ORDER BY val"?: Before: `SELECT val, cate, row_number() OVER(PARTITION BY cate) FROM testData ORDER BY cate, val;` After: `SELECT udf(val), cate, row_number() OVER(PARTITION BY cate ORDER BY val) FROM testData ORDER BY cate, udf(val)` I guess we shouldn't specify "ORDER BY val" here right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
