[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
zhengruifeng commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support URL: https://github.com/apache/spark/pull/26972#issuecomment-569875692 Merged to master, thanks all! Happy new year! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support
zhengruifeng commented on issue #26972: [SPARK-30321][ML] Log weightSum in Algo that has weights support URL: https://github.com/apache/spark/pull/26972#issuecomment-569864240 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support URL: https://github.com/apache/spark/pull/26972#issuecomment-568991530 @huaxingao Can we pass the instr of GBTClassifier/GBTRegressor into the internal impl, and use it to log the metrics in the first tree building? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support URL: https://github.com/apache/spark/pull/26972#issuecomment-568828877 Yes, current GBT impls will log these metrics for each iteration. But I guess we can just log weightSum there, if there is not an easy way to log all of them only once (at iteration 0) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo
that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568610797
I notice that other statistics for tree models are logged in
`RandomForest.run`:
```scala
instr match {
case Some(instrumentation) =>
instrumentation.logNumFeatures(metadata.numFeatures)
instrumentation.logNumClasses(metadata.numClasses)
instrumentation.logNumExamples(metadata.numExamples)
case None =>
logInfo("numFeatures: " + metadata.numFeatures)
logInfo("numClasses: " + metadata.numClasses)
logInfo("numExamples: " + metadata.numExamples)
}
```
Can we just log `weightSum` here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
