[GitHub] [spark] zhengruifeng commented on pull request #37739: [SPARK-40265][PS] Fix the inconsistent behavior for Index.intersection.

2022-09-05 Thread GitBox


zhengruifeng commented on PR #37739:
URL: https://github.com/apache/spark/pull/37739#issuecomment-1236609299

   Merged to master, thank you @itholic !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] zhengruifeng commented on pull request #37739: [SPARK-40265][PS] Fix the inconsistent behavior for Index.intersection.

2022-09-05 Thread GitBox


zhengruifeng commented on PR #37739:
URL: https://github.com/apache/spark/pull/37739#issuecomment-1236607316

   got it, `MultiIndex` has its own `intersection` method


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] zhengruifeng commented on pull request #37739: [SPARK-40265][PS] Fix the inconsistent behavior for Index.intersection.

2022-09-01 Thread GitBox


zhengruifeng commented on PR #37739:
URL: https://github.com/apache/spark/pull/37739#issuecomment-1234230281

   what if the `psidx` itself is a `MultiIndex`?
   
   ```
   >>> psidx
   Int64Index([1, 2, 3, 4], dtype='int64', name='Koalas')
   >>> psidx.intersection([(1, 2), (3, 4)]).sort_values()
   MultiIndex([], )
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org