[GitHub] [spark] zhengruifeng commented on pull request #39388: [SPARK-41354][CONNECT][PYTHON] Implement RepartitionByExpression

2023-01-08 Thread GitBox


zhengruifeng commented on PR #39388:
URL: https://github.com/apache/spark/pull/39388#issuecomment-1375190045

   merged into master, thank you @dengziming for working on this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] zhengruifeng commented on pull request #39388: [SPARK-41354][CONNECT][PYTHON] implement RepartitionByExpression

2023-01-07 Thread GitBox


zhengruifeng commented on PR #39388:
URL: https://github.com/apache/spark/pull/39388#issuecomment-1374679483

   @dengziming would you mind resolving the conflicts? thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] zhengruifeng commented on pull request #39388: [SPARK-41354][CONNECT][PYTHON] implement RepartitionByExpression

2023-01-04 Thread GitBox


zhengruifeng commented on PR #39388:
URL: https://github.com/apache/spark/pull/39388#issuecomment-1371624171

   just to confirm, the proto `RepartitionByExpression 
repartition_by_expression = 27` can support both 
   
   `def repartition(self, *cols: "ColumnOrName")`
   `def repartitionByRange(self, *cols: "ColumnOrName")`
   
   right? @dengziming 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org