[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-457430106 Merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-457430087 I am merging this based upon multiple approvals and positive feedbacks in general. I am also confident that it's isolated and non-invasive, and I expect we can fix them incrementally later since the APIs are `Unstable`. Please let me know if anyone has a concern even after it's merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-457036026 Thank you all so much. Could we maybe go forward? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-455860035 Hey all, gentle ping ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-454646029 Hey all, do you mind if I ask to take another look? I think I addressed all comments, and the changes here are not invasive at all. Doesn't change any previous behaviour but purely incremental improvement. Changes are quite isolated. Looks there are positive feedback in general about this feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-453890147 @mengxr ping .. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-453383896 @mengxr, can you take a look please when you're available? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-453367798 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-452576021 Gentle ping @mengxr This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-451716230 Gentle ping @mengxr This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-451047629 gentle ping @mengxr. I think the comment is addressed .. I know it's been a holiday period so everybody isn't quite available :). but mind if I ask to take a look please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-450536961 Hey, @mengxr, can you check if your comment is addressed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-450143241 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Instrumentation URL: https://github.com/apache/spark/pull/23263#issuecomment-449685987 @mengxr, @srowen and @felixcheung, I think I managed to integrate and address all the concerns and comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
