[GitHub] HyukjinKwon commented on issue #23470: [SPARK-26549][PySpark] Fix for python worker reuse take no effect for parallelize xrange

2019-01-07 Thread GitBox
HyukjinKwon commented on issue #23470: [SPARK-26549][PySpark] Fix for python 
worker reuse take no effect for parallelize xrange
URL: https://github.com/apache/spark/pull/23470#issuecomment-452183761
 
 
   Also, let's fix PR description and title from xrange to range as generator. 
Range in Python 3 is a generator already.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] HyukjinKwon commented on issue #23470: [SPARK-26549][PySpark] Fix for python worker reuse take no effect for parallelize xrange

2019-01-07 Thread GitBox
HyukjinKwon commented on issue #23470: [SPARK-26549][PySpark] Fix for python 
worker reuse take no effect for parallelize xrange
URL: https://github.com/apache/spark/pull/23470#issuecomment-452177786
 
 
   LGTM too considering it's a quick bandaid fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] HyukjinKwon commented on issue #23470: [SPARK-26549][PySpark] Fix for python worker reuse take no effect for parallelize xrange

2019-01-07 Thread GitBox
HyukjinKwon commented on issue #23470: [SPARK-26549][PySpark] Fix for python 
worker reuse take no effect for parallelize xrange
URL: https://github.com/apache/spark/pull/23470#issuecomment-452177584
 
 
   re: https://github.com/apache/spark/pull/23470#issuecomment-452173964
   
   Yea, I think so. I took a look to fix the root cause but it's going to be 
quite invasive from my look. Maybe there's another way I missed. So, the 
current fix is like a bandaid fix .. but I think it's good enough.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org