[GitHub] coderplay edited a comment on issue #20512: [SPARK-23182][CORE] Allow enabling TCP keep alive on the master RPC connections.
coderplay edited a comment on issue #20512: [SPARK-23182][CORE] Allow enabling TCP keep alive on the master RPC connections. URL: https://github.com/apache/spark/pull/20512#issuecomment-453769043 TCP keep alive is non-invasive, the only minor downside is that it would generate extra network packets. But thinking about spark's big data exchange use cases, these packets are negligible. I am good with this one config ruling all transport types, just please change the title/commit messages. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] coderplay edited a comment on issue #20512: [SPARK-23182][CORE] Allow enabling TCP keep alive on the master RPC connections.
coderplay edited a comment on issue #20512: [SPARK-23182][CORE] Allow enabling TCP keep alive on the master RPC connections. URL: https://github.com/apache/spark/pull/20512#issuecomment-452178010 Clarification: I am not a spark expert, just got an invitation from @rxin because he think I have some knowledge about linux TCP. Generally, the patch looks good to me for the purpose of preventing inactivity from disconnecting the channel. But from the diff, looks like this commit will impact other RPCs or shuffling transport as well. It's not only for master RPCs as the title declared. Min This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
