[GitHub] dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes.
dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some
errors in the notes.
URL: https://github.com/apache/spark/pull/23280#discussion_r240481288
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
##
@@ -101,7 +101,7 @@ package object expressions {
StructType(attrs.map(a => StructField(a.name, a.dataType, a.nullable,
a.metadata)))
}
-// It's possible that `attrs` is a linked list, which can lead to bad
O(n^2) loops when
Review comment:
Ya. The original sentence has a different context at that time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes.
dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some
errors in the notes.
URL: https://github.com/apache/spark/pull/23280#discussion_r240471322
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
##
@@ -101,7 +101,7 @@ package object expressions {
StructType(attrs.map(a => StructField(a.name, a.dataType, a.nullable,
a.metadata)))
}
-// It's possible that `attrs` is a linked list, which can lead to bad
O(n^2) loops when
Review comment:
Could you tell us why you think this comment is error? This comments came
from [SPARK-15764 Replace N^2 loop in
BindReferences](https://github.com/apache/spark/pull/13505) to explain the
problamatic situation.
> When using ordinals to access linked list, the time cost is O(n).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes.
dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some
errors in the notes.
URL: https://github.com/apache/spark/pull/23280#discussion_r240471322
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
##
@@ -101,7 +101,7 @@ package object expressions {
StructType(attrs.map(a => StructField(a.name, a.dataType, a.nullable,
a.metadata)))
}
-// It's possible that `attrs` is a linked list, which can lead to bad
O(n^2) loops when
Review comment:
Could you tell us why you think this comment is error? This comments came
from [SPARK-15764 Replace N^2 loop in
BindReferences](https://github.com/apache/spark/pull/13505) to explain the
problamatic situation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
