[GitHub] rxin commented on issue #23208: [SPARK-25530][SQL] data source v2 API refactor (batch write)
rxin commented on issue #23208: [SPARK-25530][SQL] data source v2 API refactor (batch write) URL: https://github.com/apache/spark/pull/23208#issuecomment-448851290 Honestly speaking, while I feel the need to have a great API, I feel the same way as @cloud-fan. Things have been moving very slowly. If we question every single little detail, including ones that've been settled years ago (e.g. query id), we'd never make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] rxin commented on issue #23208: [SPARK-25530][SQL] data source v2 API refactor (batch write)
rxin commented on issue #23208: [SPARK-25530][SQL] data source v2 API refactor (batch write) URL: https://github.com/apache/spark/pull/23208#issuecomment-448735776 @cloud-fan can you put the pseudocode for Spark's invocation sequence somewhere in either PR description or your doc? It's much more difficult to read a bunch of APIs without an illustration of how they will be called. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] rxin commented on issue #23208: [SPARK-25530][SQL] data source v2 API refactor (batch write)
rxin commented on issue #23208: [SPARK-25530][SQL] data source v2 API refactor (batch write) URL: https://github.com/apache/spark/pull/23208#issuecomment-448727471 @rdblue I thought the discussions there were mostly on streaming? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
