[GitHub] spark issue #11005: [SPARK-12506][SPARK-12126][SQL]use CatalystScan for JDBC...

2018-07-19 Thread kyprifog
Github user kyprifog commented on the issue:

https://github.com/apache/spark/pull/11005
  
@HyukjinKwon Thanks this is what I was looking for.  Glad the work is still 
being continued.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #11005: [SPARK-12506][SPARK-12126][SQL]use CatalystScan for JDBC...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/11005
  
BTW, datasource v2 is in progress too to allow more push downs (see 
[SPARK-22386](https://issues.apache.org/jira/browse/SPARK-22386)). You might 
want to take a look


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #11005: [SPARK-12506][SPARK-12126][SQL]use CatalystScan for JDBC...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/11005
  
Technical reason: It's kind of risky to rely on `CatalystScan` and 
completely replace the interface. I think I already see some tests were 
disabled here. Also, there look potential better suggestions above.

Practical reason: there are too many pending PRs as you see. If the author 
is not responsive and the PR is inactive to review comments, we better leave 
them closed for now - seems it's already stuck in few technical reasons. The 
author is welcome to reopen and other contributors are welcome to take over.



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #11005: [SPARK-12506][SPARK-12126][SQL]use CatalystScan for JDBC...

2018-07-18 Thread kyprifog
Github user kyprifog commented on the issue:

https://github.com/apache/spark/pull/11005
  
@rxin Why was this pull request closed?  Can you direct me to a new one 
that could have replaced it? I was trying to track down the modification of 
push downs for basic operations like "limit".


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #11005: [SPARK-12506][SPARK-12126][SQL]use CatalystScan for JDBC...

2016-06-15 Thread rxin
Github user rxin commented on the issue:

https://github.com/apache/spark/pull/11005
  
Thanks for the pull request. I'm going through a list of pull requests to 
cut them down since the sheer number is breaking some of the tooling we have. 
Due to lack of activity on this pull request, I'm going to push a commit to 
close it. Feel free to reopen it or create a new one. We can also continue the 
discussion on the JIRA ticket.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org