[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14397 LGTM (again) - merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Thank you, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63637/consoleFull)** for PR 14397 at commit [`f1f4a83`](https://github.com/apache/spark/commit/f1f4a833276c5b78309546beca9dd7a5d86590f8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63637/consoleFull)** for PR 14397 at commit [`f1f4a83`](https://github.com/apache/spark/commit/f1f4a833276c5b78309546beca9dd7a5d86590f8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Hi, @hvanhovell . Could you review this again? After the last time you've seen, only the testcase is moved into a new testsuite. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63637/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Thank you, @rxin . It's updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63595/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63595/consoleFull)** for PR 14397 at commit [`7f74ec7`](https://github.com/apache/spark/commit/7f74ec7745534b40da073c399a6439c9b03a5086). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63595/consoleFull)** for PR 14397 at commit [`7f74ec7`](https://github.com/apache/spark/commit/7f74ec7745534b40da073c399a6439c9b03a5086). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Hi, @rxin . Now the testcases are moved into `sql-tests` with `SQLQueryTestSuite`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Oh, now `Exception` is supported at https://github.com/apache/spark/commit/0db373aaf87991207a7a8a09853b6fa602f0f45b. Thanks, @rxin . I will try again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63578/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63577/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63578/consoleFull)** for PR 14397 at commit [`178813e`](https://github.com/apache/spark/commit/178813ebf6e7d5f58ebab7784e07bfd5b8c5d883). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63577/consoleFull)** for PR 14397 at commit [`624bb3d`](https://github.com/apache/spark/commit/624bb3d9f6ffe558c1897501c06c76f938e15602). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63578/consoleFull)** for PR 14397 at commit [`178813e`](https://github.com/apache/spark/commit/178813ebf6e7d5f58ebab7784e07bfd5b8c5d883). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63577/consoleFull)** for PR 14397 at commit [`624bb3d`](https://github.com/apache/spark/commit/624bb3d9f6ffe558c1897501c06c76f938e15602). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Rebased just to resolve conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63529/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63529/consoleFull)** for PR 14397 at commit [`f3a2cd4`](https://github.com/apache/spark/commit/f3a2cd43d205735d75f29ff13ebe6acebc30fa98). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63526/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63526/consoleFull)** for PR 14397 at commit [`d896afc`](https://github.com/apache/spark/commit/d896afcf94994c4383aff8b4370ac189d00469fb). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14397 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63529/consoleFull)** for PR 14397 at commit [`f3a2cd4`](https://github.com/apache/spark/commit/f3a2cd43d205735d75f29ff13ebe6acebc30fa98). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63526/consoleFull)** for PR 14397 at commit [`d896afc`](https://github.com/apache/spark/commit/d896afcf94994c4383aff8b4370ac189d00469fb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Thank you, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14397 @dongjoon-hyun this is looking very promising. I left two small comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Thank you so much! Then, see you later. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14397 @dongjoon-hyun I'll take a look in the morning (CET) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Could you review this PR again, @hvanhovell ? Last time, I did a huge mistake, but now I think I fixed correct according to your advice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63371/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63371 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63371/consoleFull)** for PR 14397 at commit [`b10ee10`](https://github.com/apache/spark/commit/b10ee106abe89649de1ff0c0b6ca3891f9ef3afb). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class With(child: LogicalPlan, cteRelations: Seq[(String, SubqueryAlias)]) extends UnaryNode ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Hi, @hvanhovell . Sorry for late update. I updated the PR description and code. Could you review this PR again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #63371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63371/consoleFull)** for PR 14397 at commit [`b10ee10`](https://github.com/apache/spark/commit/b10ee106abe89649de1ff0c0b6ca3891f9ef3afb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 The above approach also can remove the duplicated scope issue between `CTESubstitution` and `ResolveRelation`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Hi, @hvanhovell . It seems not clearly documented, so I did some comparisons. First of all, I found that I did overlooked the behavior of the Hive queries. Hive also uses CTE names first in the consecutive CTE queries like other DBMS. It's natural. ``` with t as (select 10), s as (select * from t) select * from s; ``` For the self recursion, the approaches are different. Hive/Oracle raises exceptions, PostgreSQL uses the base tables. ``` with t as (select 10 from t), s as (select * from t) select * from s; ``` The cross referencing case raises exceptions. ``` with t as (select 10 from s), s as (select * from t) select * from s; ``` To sum up, the general approach seems to - use **forward-declared(not self)** base table or CTE name - prevent the execution of cyclic queries by raising exceptions. The root cause of previous Spark behavior is using `self` or `backward-declared CTE` for table name resolutions. I will try to revise this PR according to the above rules. Please comment about the above rule. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Oh, sorry for misunderstanding, @hvanhovell . I think we can integrate `ResolveRelation` and this one. I'll be back after some testing in this evening. Also for the common approach, I will bring some references, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14397 @dongjoon-hyun New behavior versus existing systems I was not talking about recursive CTE's (which can be very useful in some cases). We are changing the behavior of the Analyzer, and this might surprise users. I would like to know if there is a common approach to this among other systems; so we can justify the change in behavior. Resolve Relations The change you propose is almost subsuming the `ResolveRelations` rule. I think it is correct to to do this. However I am not a big fan of duplicating the behavior in two rules. Do you think there is way to get around this? Could we for instance centralize the logic in `ResolveRelations`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Thank you for review, @hvanhovell . For the recursive CTE queries, traditional DBMS supports optional `RECURSIVE` keyword which computing **closures**, i.e., it iterates the subquery until the result converge. For example, PostgreSQL, MSSQL, SQLite supports `WITH RECURSIVE` syntax officially. For the overlap of `ResolveRelations` rule, this rule calls `lookupRelation` to check the name conflict between the base relations and CTEs. As a side effect, it resolves the relations, too. Here is the reasons. - To check the conflict, this is the only simplest way. - For the performance, this patch only call one `lookupRelation` for `UnresolvedRelation`. - `ResolveRelations` rule do not try resolve again and will not complain about that. - The remaining general and exceptional rules like file-based datasource should be in `ResolveRelations`. We can add more datasources there, not here. For Hive, the recursive queries and `RECURSIVE` syntax are not supported. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14397 @dongjoon-hyun I think this has merit. I do have one question, what do other databases do? Like postgresql, mysql, sqlserver and others? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14397 Hi, @rxin . Could you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62995/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #62995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62995/consoleFull)** for PR 14397 at commit [`5bca528`](https://github.com/apache/spark/commit/5bca528d971cad317f748cb3f2d050ce0b8f99a7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14397: [SPARK-16771][SQL] WITH clause should not fall into infi...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14397 **[Test build #62995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62995/consoleFull)** for PR 14397 at commit [`5bca528`](https://github.com/apache/spark/commit/5bca528d971cad317f748cb3f2d050ce0b8f99a7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
